Skip to content

Inherit isolation from the closure definition context #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Inherit isolation from the closure definition context #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Sources/JavaScriptKit/FundamentalObjects/JSClosure.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public class JSOneshotClosure: JSObject, JSClosureProtocol {
priority: TaskPriority? = nil,
file: String = #fileID,
line: UInt32 = #line,
_ body: sending @escaping (sending [JSValue]) async throws(JSException) -> JSValue
_ body: @escaping (sending [JSValue]) async throws(JSException) -> JSValue
) -> JSOneshotClosure {
JSOneshotClosure(file: file, line: line, makeAsyncClosure(priority: priority, body))
}
Expand All @@ -71,7 +71,7 @@ public class JSOneshotClosure: JSObject, JSClosureProtocol {
priority: TaskPriority? = nil,
file: String = #fileID,
line: UInt32 = #line,
_ body: @Sendable @escaping (sending [JSValue]) async throws(JSException) -> JSValue
_ body: @escaping (sending [JSValue]) async throws(JSException) -> JSValue
) -> JSOneshotClosure {
JSOneshotClosure(
file: file,
Expand Down Expand Up @@ -176,7 +176,7 @@ public class JSClosure: JSFunction, JSClosureProtocol {
priority: TaskPriority? = nil,
file: String = #fileID,
line: UInt32 = #line,
_ body: sending @escaping @isolated(any) (sending [JSValue]) async throws(JSException) -> JSValue
_ body: @escaping @isolated(any) (sending [JSValue]) async throws(JSException) -> JSValue
) -> JSClosure {
JSClosure(file: file, line: line, makeAsyncClosure(priority: priority, body))
}
Expand All @@ -193,7 +193,7 @@ public class JSClosure: JSFunction, JSClosureProtocol {
priority: TaskPriority? = nil,
file: String = #fileID,
line: UInt32 = #line,
_ body: sending @escaping (sending [JSValue]) async throws(JSException) -> JSValue
_ body: @escaping (sending [JSValue]) async throws(JSException) -> JSValue
) -> JSClosure {
JSClosure(file: file, line: line, makeAsyncClosure(executorPreference: taskExecutor, priority: priority, body))
}
Expand All @@ -212,7 +212,7 @@ public class JSClosure: JSFunction, JSClosureProtocol {
@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
private func makeAsyncClosure(
priority: TaskPriority?,
_ body: sending @escaping @isolated(any) (sending [JSValue]) async throws(JSException) -> JSValue
_ body: @escaping @isolated(any) (sending [JSValue]) async throws(JSException) -> JSValue
) -> ((sending [JSValue]) -> JSValue) {
{ arguments in
JSPromise { resolver in
Expand Down Expand Up @@ -241,7 +241,7 @@ private func makeAsyncClosure(
private func makeAsyncClosure(
executorPreference taskExecutor: (any TaskExecutor)?,
priority: TaskPriority?,
_ body: sending @escaping (sending [JSValue]) async throws(JSException) -> JSValue
_ body: @escaping (sending [JSValue]) async throws(JSException) -> JSValue
) -> ((sending [JSValue]) -> JSValue) {
{ arguments in
JSPromise { resolver in
Expand Down