Rework treatment of built-in packages #16938
Merged
+109
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnussbaum
force-pushed
the
fix-package-updates
branch
from
b3c8160 to
a00cb4b
Compare
fnussbaum
changed the title
fnussbaum
added a commit
to fnussbaum/spacemacs
that referenced
this pull request
Apr 21, 2025
This allows programmatically updating specific packages (I am using this for testing syl20bnr#16938, for example). It also prepares the possibility of selecting packages to update through embark. Additionally, it might be slightly easier to read.
bcc32
pushed a commit
to fnussbaum/spacemacs
that referenced
this pull request
Apr 26, 2025
This allows programmatically updating specific packages (I am using this for testing syl20bnr#16938, for example). It also prepares the possibility of selecting packages to update through embark. Additionally, it might be slightly easier to read.
Transient is a built-in package, and also a dependency of many other packages users might install. It makes more sense to always configure it, also when the git layer is not used.
Previously, if no location was specified, it was set to the default `elpa`. This did not mean, however, that the packages where installed from ELPA; the built-in packages were used regardless (they might not even be published on an ELPA, of course). Now we correctly set the location to `built-in`, in preparation to making `:location elpa` take effect for built-in packages, too.
fnussbaum
force-pushed
the
fix-package-updates
branch
2 times, most recently
from
9e4a1b2 to
00174d5
Compare
We need to account for built-in packages when installing, checking availability of new versions, updating, and rolling back packages. Also refactor the last call site of configuration-layer//delete-package that used package names instead of pkg-desc objects (namely configuration-layer/rollback), such that we can simplify the function.
The package will now get updated by `configuration-layer/update-packages`. We do not need to manually bump the version anymore.
fnussbaum
force-pushed
the
fix-package-updates
branch
from
00174d5 to
4e1894e
Compare
fnussbaum
changed the title
|
This is now ready for review. I had no problems with updating packages with these commits in the last months, whereas before I frequently encountered broken package installations. I also vaguely remember quite a few reported issues that were related or caused by these load- and installation-order subtleties. |
|
@bcc32 @smile13241324 (There is no rush, take your time, just pinging again in case the notification got lost.) |
|
Whups this got lost i'll do a test today, thsnks for pinging :) @fnussbaum |
fnussbaum
added a commit
that referenced
this pull request
Nov 1, 2025
One instance of the deprecated oref slot syntax remained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent frequent errors after updating packages, caused by outdated versions of built-in packages being loaded. We also ensure transient and org get updated, without having to manually bump the
:min-versionparameter. More generally, this PR allows installing built-in packages from arbitrary locations, for example by adding them todotspacemacs-additional-packageswith a custom quelpa recipe.