Make Basic.has behave more like SymPy, use new visitor #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
reviewed
Jul 29, 2025
symengine/__init__.py
Outdated
| @@ -19,7 +19,7 @@ | |||
| Max, Min, DenseMatrix, Matrix, | |||
| ImmutableMatrix, ImmutableDenseMatrix, MutableDenseMatrix, | |||
| MatrixBase, Basic, DictBasic, symarray, series, diff, zeros, | |||
| eye, diag, ones, Derivative, Subs, expand, has_symbol, | |||
| eye, diag, ones, Derivative, Subs, expand, has_basic, has_symbol, | |||
There was a problem hiding this comment.
Let's not export has_basic and use .has
bjodah
commented
Jul 29, 2025
| def has(self, *symbols): | ||
| return any([has_symbol(self, symbol) for symbol in symbols]) | ||
| def has(self, *args): | ||
| for arg in args: |
There was a problem hiding this comment.
The loop here begs the question:
Should HasBasicVisitor's looking_for_ rather be a vec_basic instead of a simple rcp_basic? If it's common to query with multiple arguments, then a vec_basic would avoid traversing the (possibly large) syntax tree multiple times, but if the majority of use cases only matches against a single argument, that would be a pessimisation, what do you think?
|
ready for review. |
isuruf
changed the title
isuruf
approved these changes
Aug 4, 2025
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes gh-515
This would require: