Skip to content

[Platform][Agent] Rework Platform API to invoke and result #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025

Conversation

chr-hertel
Copy link
Contributor

@chr-hertel chr-hertel commented Jul 18, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #141
License MIT

We can change the naming later, they said. PhpStorm has great tooling for that, they said. 😆 🙈

I skipped the ResponseFactory for now - not sure about the Agent vs Platform API and differences here.

@chr-hertel chr-hertel changed the title Rework Platform API to invoke and result [Platform][Agent] Rework Platform API to invoke and result Jul 18, 2025
@chr-hertel chr-hertel added Platform Issues & PRs about the AI Platform component Agent Issues & PRs about the AI Agent component BC Break Breaking the Backwards Compatibility Promise labels Jul 18, 2025
@OskarStark
Copy link
Contributor

Where is the added line? 😄
CleanShot 2025-07-18 at 19 37 30@2x

@chr-hertel
Copy link
Contributor Author

chr-hertel commented Jul 18, 2025

Where is the added line? 😄

Wouldn't it take away the fun of reviewing if I'd tell you right away? 😂

Comment on lines 20 to 23
#[CoversClass(StreamResult::class)]
#[Small]
final class StreamResponseTest extends TestCase
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class name correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noo, please don't review - it's incomplete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now 🎉

@chr-hertel chr-hertel force-pushed the refactor-rename-response-result branch 3 times, most recently from 2386a51 to 8584c5f Compare July 18, 2025 22:42
@chr-hertel chr-hertel marked this pull request as ready for review July 18, 2025 22:44
@chr-hertel chr-hertel requested a review from Nyholm as a code owner July 18, 2025 22:44
@chr-hertel chr-hertel force-pushed the refactor-rename-response-result branch from 8584c5f to 9f0eec0 Compare July 19, 2025 20:08
@chr-hertel
Copy link
Contributor Author

Merging in alignment with Oskar without approvals - not great to review anyways, sorry 😬 😇

@chr-hertel chr-hertel merged commit 1d5dabb into main Jul 19, 2025
26 checks passed
@chr-hertel chr-hertel deleted the refactor-rename-response-result branch July 19, 2025 21:07
@chr-hertel chr-hertel mentioned this pull request Jul 20, 2025
chr-hertel added a commit that referenced this pull request Jul 20, 2025
This PR was merged into the main branch.

Discussion
----------

[AIBundle] Fix dependency injection

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Docs?         | no
| License       | MIT

Fix DI config after #163 / #154. Should've rebased before merge – now we're getting a bunch of errors on `main`:

```
Symfony\AI\Agent\Toolbox\Toolbox::__construct(): Argument #1 ($tools) must be of type Traversable|array, Symfony\AI\Agent\Toolbox\ToolFactory\ReflectionToolFactory given
```

etc

Commits
-------

3c6290e [AIBundle] Fix dependency injection config after #163
chr-hertel added a commit that referenced this pull request Jul 27, 2025
…ts (chr-hertel)

This PR was merged into the main branch.

Discussion
----------

[Platform] Renamed some Response leftovers in Platform tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Docs?         | no
| Issues        |
| License       | MIT

Follow up on #154

Commits
-------

43c44ca Renamed some Response leftovers in Platform tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Issues & PRs about the AI Agent component BC Break Breaking the Backwards Compatibility Promise Platform Issues & PRs about the AI Platform component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC][Platform] Renaming Response to Result
2 participants