-
-
Notifications
You must be signed in to change notification settings - Fork 41
[Platform][Agent] Rework Platform API to invoke and result #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wouldn't it take away the fun of reviewing if I'd tell you right away? 😂 |
#[CoversClass(StreamResult::class)] | ||
#[Small] | ||
final class StreamResponseTest extends TestCase | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class name correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noo, please don't review - it's incomplete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now 🎉
2386a51
to
8584c5f
Compare
8584c5f
to
9f0eec0
Compare
Merging in alignment with Oskar without approvals - not great to review anyways, sorry 😬 😇 |
This PR was merged into the main branch. Discussion ---------- [AIBundle] Fix dependency injection | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | License | MIT Fix DI config after #163 / #154. Should've rebased before merge – now we're getting a bunch of errors on `main`: ``` Symfony\AI\Agent\Toolbox\Toolbox::__construct(): Argument #1 ($tools) must be of type Traversable|array, Symfony\AI\Agent\Toolbox\ToolFactory\ReflectionToolFactory given ``` etc Commits ------- 3c6290e [AIBundle] Fix dependency injection config after #163
…ts (chr-hertel) This PR was merged into the main branch. Discussion ---------- [Platform] Renamed some Response leftovers in Platform tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Follow up on #154 Commits ------- 43c44ca Renamed some Response leftovers in Platform tests
We can change the naming later, they said. PhpStorm has great tooling for that, they said. 😆 🙈
I skipped the ResponseFactory for now - not sure about the Agent vs Platform API and differences here.