[MCP SDK] Add server capabilities toSymfony\AI\McpSdk\Server\RequestHandler\InitializeHandler
#305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineersa
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Feature
ineersa
commented
Aug 12, 2025
| */ | ||
| public function jsonSerialize(): array | ||
| { | ||
| return array_filter((array) $this, fn ($value) => null !== $value); |
There was a problem hiding this comment.
It doesn't look nice, ideally it would be better to use centralized solution in \Symfony\AI\McpSdk\Message\Response::jsonSerialize.
Serializer with AbstractObjectNormalizer::SKIP_NULL_VALUES would fit perfectly, but it's not in dependencies list.
OskarStark
changed the title
Symfony\AI\McpSdk\Server\RequestHandler\InitializeHandler
OskarStark
reviewed
Aug 13, 2025
Comment on lines
14
to
19
| enum ProtocolVersionEnum: string | ||
| { | ||
| case V2024_11_05 = '2024-11-05'; | ||
| case V2025_03_26 = '2025-03-26'; | ||
| case V2025_06_18 = '2025-06-18'; | ||
| } |
There was a problem hiding this comment.
Suggested change
| enum ProtocolVersionEnum: string | |
| { | |
| case V2024_11_05 = '2024-11-05'; | |
| case V2025_03_26 = '2025-03-26'; | |
| case V2025_06_18 = '2025-06-18'; | |
| } | |
| enum ProtocolVersion: string | |
| { | |
| case VERSION_2024_11_05 = '2024-11-05'; | |
| case VERSION_2025_03_26 = '2025-03-26'; | |
| case VERSION_2025_06_18 = '2025-06-18'; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Server capabilities classes, Enum for protocol version, updated
InitializeHandler.Added skip null values at JSON serialization.
Added
InitializeHandlerTest.Updated docs and example.