[Platform][Gemini] Do tool call if any contentPart is a functionCall
#703
+87
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrauzJu
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Status: Needs Review
Bug
OskarStark
reviewed
Sep 30, 2025
src/platform/tests/Bridge/Gemini/Gemini/ResultConverterTest.php
Outdated
Show resolved
Hide resolved
|
I think the same needs to be done for the vertexai bridge, right? |
OskarStark
changed the title
contentPart is a functionCall
@OskarStark Probably yes, but I never used it so far. I can try it though. |
|
The code should look quite similar, can you try adding your fix there too? Thanks |
DrauzJu
force-pushed
the
gemini-result-converter
branch
from
1b58da5 to
e124679
Compare
OskarStark
approved these changes
Oct 2, 2025
OskarStark
changed the title
contentPart is a functionCallcontentPart is a functionCall
OskarStark
force-pushed
the
gemini-result-converter
branch
from
e124679 to
c3c36ab
Compare
|
Thanks for fixing this bug Julian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gemini API may return multiple content parts even if a tool call is desired. For example, one content part can be an explanation why the tool was called. This PR adds support for this by first checking if any content part is a
functionCall. If so, all other content parts are discarded and the function/tool call is processed.