Skip to content

[Chat] Introduce DoctrineDbalMessageStore #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

[Chat] Introduce DoctrineDbalMessageStore #884

merged 1 commit into from
Nov 20, 2025

Conversation

@Guikingone
Copy link
Contributor

@Guikingone Guikingone commented Nov 17, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues #16
License MIT

@OskarStark
Copy link
Contributor

OskarStark commented Nov 18, 2025 •
edited
Loading

Lets rename it to DoctrineOrmMessageStore?

@welcoMattic
Copy link
Member

welcoMattic commented Nov 18, 2025

I would say even DoctrineDbalMessageStore as doctrine/dbal is used and not doctrine/orm

@Guikingone
Copy link
Contributor Author

Guikingone commented Nov 18, 2025

Agree with @welcoMattic, I would prefer DoctrineDbalMessageStore as we also need to support the ODM.

@Guikingone Guikingone changed the title [Chat] Introduce OrmMessageStore via Doctrine [Chat] Introduce DoctrineDbalMessageStore via Doctrine Nov 18, 2025
@Guikingone
Copy link
Contributor Author

Guikingone commented Nov 18, 2025 •
edited
Loading

@OskarStark @chr-hertel

Looks like fabbot is not totally operational:

Capture d’écran 2025-11-18 à 19 39 25

The hashTable method does not exist 😅

@Guikingone Guikingone force-pushed the chat/doctrine_orm branch 2 times, most recently from 1b2214c to 60902bd Compare November 18, 2025 20:10
@Guikingone Guikingone marked this pull request as ready for review November 18, 2025 20:10
@carsonbot carsonbot added Chat Issues & PRs about the AI Chat component Feature New feature Status: Needs Review labels Nov 18, 2025
welcoMattic
welcoMattic reviewed Nov 19, 2025
View reviewed changes
@OskarStark OskarStark changed the title [Chat] Introduce DoctrineDbalMessageStore via Doctrine [Chat] Introduce DoctrineDbalMessageStore Nov 19, 2025
derrabus
derrabus reviewed Nov 19, 2025
View reviewed changes
@Guikingone Guikingone force-pushed the chat/doctrine_orm branch 2 times, most recently from 9a3ce8c to 8e30b35 Compare November 19, 2025 17:29
@Guikingone
Copy link
Contributor Author

Guikingone commented Nov 19, 2025

@derrabus I don't know if I can ask the question and/or if Doctrine project is using codespell but I'm facing a weird error in CI (see #884 (comment)), could this be related to any internal API from Doctrine? 🤔

OskarStark
OskarStark reviewed Nov 20, 2025
View reviewed changes
OskarStark
OskarStark reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, then good to merge from my side

@OskarStark
Copy link
Contributor

OskarStark commented Nov 20, 2025

Thank you @Guikingone.

@OskarStark OskarStark merged commit ff7e808 into symfony:main Nov 20, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark left review comments

@chr-hertel chr-hertel Awaiting requested review from chr-hertel chr-hertel is a code owner

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

@derrabus derrabus Awaiting requested review from derrabus

@welcoMattic welcoMattic Awaiting requested review from welcoMattic

Assignees

No one assigned

Labels

Chat Issues & PRs about the AI Chat component Feature New feature Status: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Guikingone @OskarStark @welcoMattic @derrabus @carsonbot