Skip to content

fix(pgsql): harden ProxySQL against backend failures during result fetch - #6111

Open
rahim-kanji wants to merge 13 commits into
v3.0from
v3.0_fix-pgsql-backend-reply-handling-6109-6110
Open

fix(pgsql): harden ProxySQL against backend failures during result fetch#6111
rahim-kanji wants to merge 13 commits into
v3.0from
v3.0_fix-pgsql-backend-reply-handling-6109-6110

test(pgsql): make the query-cache scenario prove it ran

50f093a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 21, 2026 in 9m 38s

Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 344 in test/tap/tests/pgsql_mock_backend.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvSLs3Kbel7NkL_&open=AaAVcyvSLs3Kbel7NkL_&pullRequest=6111

Check failure on line 37 in test/tap/tests/pgsql-reg_test_6109_midresult_terminate_backend-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 59 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyu5Ls3Kbel7NkL3&open=AaAVcyu5Ls3Kbel7NkL3&pullRequest=6111

Check failure on line 87 in test/tap/tests/pgsql_mock_backend.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "U" suffix to this constant, to make it explicitly "unsigned". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvSLs3Kbel7NkL7&open=AaAVcyvSLs3Kbel7NkL7&pullRequest=6111

Check failure on line 433 in test/tap/tests/pgsql-reg_test_6110_invalid_reply_sequence-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 45 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcycCLs3Kbel7NkL1&open=AaAVcycCLs3Kbel7NkL1&pullRequest=6111

Check failure on line 707 in test/tap/tests/pgsql-reg_test_6109_midresult_disconnect-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture "admin", "adminOwner", "saved_monitor", "saved_shun", "saved_conn_to", "saved_thresh" in a non-transient lambda. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvGLs3Kbel7NkL6&open=AaAVcyvGLs3Kbel7NkL6&pullRequest=6111

Check failure on line 321 in test/tap/tests/pgsql-reg_test_6110_invalid_reply_sequence-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 36 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAfwg8J6XJlW4uxyPz7&open=AaAfwg8J6XJlW4uxyPz7&pullRequest=6111

Check failure on line 313 in test/tap/tests/pgsql_mock_backend.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 61 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvSLs3Kbel7NkL9&open=AaAVcyvSLs3Kbel7NkL9&pullRequest=6111

Check failure on line 323 in test/tap/tests/pgsql-reg_test_6109_midresult_disconnect-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 36 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvGLs3Kbel7NkL4&open=AaAVcyvGLs3Kbel7NkL4&pullRequest=6111

Check failure on line 343 in test/tap/tests/pgsql_mock_backend.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvSLs3Kbel7NkL-&open=AaAVcyvSLs3Kbel7NkL-&pullRequest=6111

Check failure on line 314 in test/tap/tests/pgsql_mock_backend.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture "this" in a non-transient lambda. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvSLs3Kbel7NkMC&open=AaAVcyvSLs3Kbel7NkMC&pullRequest=6111

Check failure on line 367 in test/tap/tests/pgsql_mock_backend.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvSLs3Kbel7NkMB&open=AaAVcyvSLs3Kbel7NkMB&pullRequest=6111

Check failure on line 220 in test/tap/tests/pgsql_mock_backend.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvSLs3Kbel7NkL8&open=AaAVcyvSLs3Kbel7NkL8&pullRequest=6111

Check failure on line 687 in test/tap/tests/pgsql-reg_test_6109_midresult_disconnect-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 33 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvGLs3Kbel7NkL5&open=AaAVcyvGLs3Kbel7NkL5&pullRequest=6111

Check failure on line 126 in test/tap/tests/pgsql-reg_test_6109_midresult_terminate_backend-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAfwhO76XJlW4uxyPz8&open=AaAfwhO76XJlW4uxyPz8&pullRequest=6111

Check failure on line 345 in test/tap/tests/pgsql_mock_backend.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvSLs3Kbel7NkMA&open=AaAVcyvSLs3Kbel7NkMA&pullRequest=6111

Check failure on line 447 in test/tap/tests/pgsql-reg_test_6110_invalid_reply_sequence-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture "admin", "adminOwner", "saved_monitor", "saved_shun", "saved_conn_to" in a non-transient lambda. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcycCLs3Kbel7NkL2&open=AaAVcycCLs3Kbel7NkL2&pullRequest=6111

Check failure on line 705 in lib/PgSQL_Connection.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAfwhS16XJlW4uxyPz9&open=AaAfwhS16XJlW4uxyPz9&pullRequest=6111

Check failure on line 351 in test/tap/tests/pgsql_mock_backend.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call a function from <locale> instead of a function from <ctype.h>. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAVcyvSLs3Kbel7NkMD&open=AaAVcyvSLs3Kbel7NkMD&pullRequest=6111
View more details on SonarQubeCloud