-
Notifications
You must be signed in to change notification settings - Fork 585
Improve readability and maintainability #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
d11d0a3
to
2fe17d0
Compare
Break long lines, adjust phrasing, and add minor clarifications to make the text more consistent and easier to follow. This is a formatting-only change with no semantic modifications. Signed-off-by: Chia-Hao Chiu <[email protected]>
2fe17d0
to
ba488ec
Compare
% TODO: adjust the section anchor | ||
You can now use whatever name you like for the start and end functions of a module, and you will learn how to do this in Section \ref{hello_n_goodbye}. | ||
You can now use whatever name you like for the start and end functions of a module, | ||
and you will learn how to do this in Section \ref{hello_n_goodbye}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer \Cref{...}
over Section \ref{...}
for better maintenance.
Other places could also be updated. Feel free to open a PR if convenient!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer
\Cref{...}
overSection \ref{...}
for better maintenance. Other places could also be updated. Feel free to open a PR if convenient!
\Cref
triggered Undefined control sequence since cleveref
is not loaded. If we want cleveref
later, I can open a separate PR to handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\Cref
triggered Undefined control sequence sincecleveref
is not loaded. If we wantcleveref
later, I can open a separate PR to handle it.
Support cleveref in another pull request.
Thank @Jordymalone for contributing! |
Break long lines, adjust phrasing, and add minor clarifications to make the text more consistent and easier to follow. This is a formatting-only change with no semantic modifications.
Summary by cubic
Improves readability and maintainability of lkmpg.tex by wrapping long lines and tightening wording. Formatting-only change with no semantic edits.