Skip to content

Update device detection #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ajkenah
Copy link

@ajkenah ajkenah commented Dec 17, 2021

Update USB device detection to be based on the device which the invoked script is hosted on. This removes the requirement for the Get-USBDeviceId Function which assumes that the USB device is device[0] if multiple devices exist.

Aaron Kenah added 3 commits December 17, 2021 23:27
…ed script is hosted on. This removes the requirement for the Get-USBDeviceId Function which assumes that the USB device is device[0] if multiple devices exist... There's also some selfish changes in here that enable the capability to run from a VHD file as initially referenced in your videos.
@ajkenah
Copy link
Author

ajkenah commented Dec 17, 2021

Hi @tabs-not-spaces I hope you don't mind me proposing some optimisations to your code base. :)
These changes came about because I was trying to create a bootable VHDX file as per your YouTube video for testing purposes, but it was failiing because there wasn't a USB device. So I took a look through the code for the Invoke-Provision.ps1 script and came up with this optimisation.
Please feel free to reject or we can discuss further if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant