Skip to content

Clarify documentation about lifetimes of the events and attributes - #1006

Merged
dralley merged 1 commit into
tafia:masterfrom
Mingun:clarify-lifetimes
Aug 22, 2026
Merged

dralley merged 1 commit into
tafia:masterfrom
Mingun:clarify-lifetimes

Conversation

@Mingun

@Mingun Mingun commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Use self-describing lifetime names

Closes #331

@Mingun Mingun added enhancement documentation Issues about improvements or bugs in documentation labels Aug 22, 2026
@Mingun
Mingun requested a review from dralley August 22, 2026 14:42
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 64.28571% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.28%. Comparing base (e00ae5c) to head (e5c2e30).
⚠️ Report is 63 commits behind head on master.

Files with missing lines Patch % Lines
src/events/mod.rs 64.28% 20 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   57.31%   55.28%   -2.04%     
==========================================
  Files          46       51       +5     
  Lines       18197    18721     +524     
==========================================
- Hits        10429    10349      -80     
- Misses       7768     8372     +604     
Flag Coverage Δ
unittests 55.28% <64.28%> (-2.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dralley
dralley merged commit f4db767 into tafia:master Aug 22, 2026
7 checks passed
@Mingun
Mingun deleted the clarify-lifetimes branch August 22, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues about improvements or bugs in documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't use 'a for the underlying slice's lifetime

3 participants