Skip to content

Add support for the ipsets section #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2024
Merged

Add support for the ipsets section #22

merged 2 commits into from
Nov 4, 2024

Conversation

jof
Copy link
Contributor

@jof jof commented Oct 30, 2024

Addresses #21

@samlinville samlinville requested a review from clstokes October 30, 2024 21:48
clstokes
clstokes requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@clstokes clstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment about the proposed change and requested updates to ensure tests pass.

@jof jof requested a review from clstokes November 1, 2024 07:06
clstokes
clstokes approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@clstokes clstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@clstokes clstokes merged commit a9d8794 into tailscale-dev:main Nov 4, 2024
1 check passed
@clstokes clstokes mentioned this pull request Nov 6, 2024
Closed
@nitper nitper mentioned this pull request May 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clstokes clstokes clstokes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jof @clstokes