Allow to use pre-installed binaries #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I tested the latest commit in a personal project and it worked nicely. |
|
@borchero , could you rebase this |
|
@jayvdb sorry for the delay, finally done 😄 |
jayvdb
reviewed
Jun 16, 2024
jayvdb
approved these changes
Jun 17, 2024
|
ping @knyar & @patrickod & @willnorris |
|
bump, just in case |
|
I'm not really sure what to do to link an already present binary on Windows -- do I need to do anything if it's on the path? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Potentially,
tailscale(d?)have been installed via a separate workflow step to manage the Tailscale version via an external tool (e.g. viaconda-forge- tailscale, tailscaled). This change allowstailscale/github-actionaction to simply use these installed binaries rather than forcing the user to download additional binaries.