conditionally compile released SQLite on ifndef SQLITE_TRUNK - #142
Merged
Conversation
Also log a warning when SQLite trunk detects when the WAL is wrapped after the header was read for a checkpoint. Updates tailscale/corp#37997 Signed-off-by: Percy Wegmann <percy@tailscale.com>
sailorfrag
approved these changes
Mar 4, 2026
icy
reviewed
Aug 15, 2026
| ** the wal file. It would also be dangerous to proceed, as there may be | ||
| ** fewer than pWal->hdr.mxFrame valid frames in the wal file. */ | ||
| int bChg = memcmp(pLive->aSalt, pWal->hdr.aSalt, sizeof(pWal->hdr.aSalt)); | ||
| if( bChg ) sqlite3_log(SQLITE_WARNING, "wal wrapped after header was read for this checkpoint"); |
There was a problem hiding this comment.
this is mentioned on https://tailscale.com/blog/sqlite-wal-reset-bug#party-time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also log a warning when SQLite trunk detects when the WAL is wrapped after the header was read for a checkpoint.
Updates tailscale/corp#37997