Skip to content

Conversation

mnahkies
Copy link
Contributor

@mnahkies mnahkies commented Aug 31, 2025

Edit: repurposed to check fmt during CI

  • add fmt job to the android github actions workflow
  • re-introduce hint error message on make fmt-check failure
  • update readme

stacked on #696 this change simply runs the new make lint command to reformat the code.

I wasn't sure how annoying to review this would be, and so figured there is a decent chance a maintainer might prefer to run themselves (essentially replacing this PR).

@bradfitz
Copy link
Member

bradfitz commented Aug 31, 2025

It should probably also have CI coverage to prevent regressions in the future.

Edit: I should've read #696 first :)

@mnahkies mnahkies force-pushed the mn/chore/reformat-code branch from 4923ecd to 14088a7 Compare September 3, 2025 05:49
@mnahkies
Copy link
Contributor Author

mnahkies commented Sep 3, 2025

It should probably also have CI coverage to prevent regressions in the future.

Edit: I should've read #696 first :)

Given the diff isn't as bad to review as I'd guessed it might be, I'd be happy to fold this into #696 now that it's been demonstrated to do its job in CI correctly.

@mnahkies mnahkies force-pushed the mn/chore/reformat-code branch from 14088a7 to 124f157 Compare September 5, 2025 06:51
@mnahkies mnahkies changed the title chore: reformat code ci: make fmt-check during ci Sep 5, 2025
Signed-off-by: Michael Nahkies <[email protected]>
@mnahkies mnahkies force-pushed the mn/chore/reformat-code branch from 124f157 to ee90d0f Compare September 5, 2025 06:52
@mnahkies
Copy link
Contributor Author

mnahkies commented Sep 5, 2025

@bradfitz I've rebased this on main and repurposed to only add the make fmt-check CI job now that #696 is merged 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants