Add css-language-server to binary list
#1437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the binary is place into
node_modules/.bin. Before you'd have to path intonode_modules/@tailwindcss/language-server/bin/css-language-serverto get access to it.This was done on purpose originally as it's just a fork of VSCode's CSS language server + some additions and really was just to improve test coverage. I'd thought about possibly folding this functionality directly into the main language server so completions could eventually be a bit smarter but that's a larger effort (if it's even reasonable at all — no idea).
In the meantime it feels reasonable to me to mark this so it's treated as a binary by package managers.