Skip to content

fix: don't try to make relative an file: url #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: don't try to make relative an file: url #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b76a3e
fix: don't try to make relative an absolute url
mshima Dec 4, 2022
01074fa
add test for url stack
mshima Dec 4, 2022
e8b9691
add missing test
mshima Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ class StackUtils {
}
}

st = st.replace(`${this._cwd}/`, '');
if (!/file:/.test(st)) {
st = st.replace(`${this._cwd}/`, '');
}

if (st) {
if (isAtLine) {
Expand Down
4 changes: 4 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ t.test('clean: truncates cwd', t => {
'foo (foo.js:3:8)',
'bar (foo.js:7:2)',
'bar (bar.js:4:2)',
'url (file:///user/dev/project/bar.mjs:8:9)',
'Object.<anonymous> (bar.js:7:1)',
'ontimeout (timers.js:365:14)',
'tryOnTimeout (timers.js:237:5)',
Expand Down Expand Up @@ -80,6 +81,7 @@ t.test('clean: eliminates internals', t => {
'foo (project/foo.js:3:8)',
'bar (project/foo.js:7:2)',
'bar (project/bar.js:4:2)',
'url (file:///user/dev/project/bar.mjs:8:9)',
'Object.<anonymous> (project/bar.js:7:1)'
]);
t.equal(stack.clean(LinuxStack1), expected);
Expand Down Expand Up @@ -392,6 +394,7 @@ function linuxStack1() {
' at foo (/user/dev/project/foo.js:3:8)',
' at bar (/user/dev/project/foo.js:7:2)',
' at bar (/user/dev/project/bar.js:4:2)',
' at url (file:///user/dev/project/bar.mjs:8:9)',
' at Object.<anonymous> (/user/dev/project/bar.js:7:1)'
];
}
Expand All @@ -402,6 +405,7 @@ function windowsStack1() {
' at foo (Z:\\user\\dev\\project\\foo.js:3:8)',
' at bar (Z:\\user\\dev\\project\\foo.js:7:2)',
' at bar (Z:\\user\\dev\\project\\bar.js:4:2)',
' at url (file:///user/dev/project/bar.mjs:8:9)',
' at Object.<anonymous> (Z:\\user\\dev\\project\\bar.js:7:1)'
];
}
Expand Down