-
Notifications
You must be signed in to change notification settings - Fork 5
Add partition files amount limit #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…enerator output config tests
8dc7caf
to
ce74fd6
Compare
@@ -0,0 +1,119 @@ | |||
package confirm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be beneficial to move confirm to the render package and generally implement it as a renderer structure method.
type DummyReadWriteCloser struct { | ||
io.Reader | ||
io.Writer | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be renamed to nopReadWriteCloser to match the standard library, but that's a matter of taste.
Summary
This PR introduces the
partition_files_limit
parameter for CSV and Parquet output writers.CLI changes
Testing notes
promptu
i package contains a data race that becomes visible when running tests with the-race
flag and callingpromptui.Run()
.