ci: turn on linters #1185
Merged
ci: turn on linters #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmyger
requested review from
oleg-jukovec,
AlexandrLitkevich,
elhimov and
patapenka-alexey
1 task
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
2b4a206 to
59e26ec
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
58058fc to
45cce06
Compare
AlexandrLitkevich
approved these changes
Jul 11, 2025
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
59e26ec to
e155128
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
45cce06 to
9a85455
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
e155128 to
b4547b7
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
9a85455 to
0beb8b5
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
b4547b7 to
20a96d7
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
0beb8b5 to
ca78a15
Compare
oleg-jukovec
approved these changes
Jul 17, 2025
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
20a96d7 to
707afff
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
ca78a15 to
8657ea5
Compare
elhimov
requested changes
Jul 22, 2025
There was a problem hiding this comment.
Sorry, but I don't catch the point of splitting into 2 PRs. The first one (#1184) turns off the job and the second one (this PR) turns it back. I would understand if this job fails in #1184 and then I would expect that it is fixed with this PR and turned back, but I see no fix, it just turned back. Would you please clarify? Why don't we just keep this job intact in #1184 and drop this PR?
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
2 times, most recently
from
25a4d6e to
89506dd
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
8657ea5 to
c1fa1f1
Compare
Please check comment: #1184 (comment) |
Got it, thanks! |
elhimov
approved these changes
Jul 24, 2025
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
89506dd to
da4751e
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
c1fa1f1 to
40b47f9
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
da4751e to
0e01c6d
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
40b47f9 to
8ff567b
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
8ff567b to
55ecb7c
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
0e01c6d to
400e4db
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
55ecb7c to
caddb4b
Compare
Base automatically changed from
dmyger/tntp-3105_turn_on_spell_checker_for_code
to
master
July 25, 2025 15:25
Part of #TNTP-3105
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code_p2
branch
from
caddb4b to
d2cdc88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on static code analyzes.
Second part for #1184
Part of #TNTP-3105