switch: minor adjustment of command output #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhimov
force-pushed
the
elhimov/tntp-3886-adjust-failover-switch-output
branch
from
6d78687 to
7fea915
Compare
elhimov
force-pushed
the
elhimov/tntp-3886-adjust-failover-switch-output
branch
from
7fea915 to
fb57030
Compare
dmyger
approved these changes
Jul 28, 2025
patapenka-alexey
approved these changes
Jul 29, 2025
oleg-jukovec
requested changes
Jul 30, 2025
elhimov
force-pushed
the
elhimov/tntp-3886-adjust-failover-switch-output
branch
from
fb57030 to
90ba804
Compare
At the end of its output `switch` displays command `switch-status` with the corresponding arguments that allows to check status of switching. This patch wraps uri argument of that command with quotes as it may contain characters that have special meaning for shell, thus it simplify subsequent call of `switch-status` command because now it can be copy-pasted from the output as-is. Closes #1194 @TarantoolBot document Title: `tt cluster failover switch` simplify subsequent launch of `switch-status`.
elhimov
force-pushed
the
elhimov/tntp-3886-adjust-failover-switch-output
branch
from
90ba804 to
b577239
Compare
Done. |
oleg-jukovec
approved these changes
Aug 7, 2025
oleg-jukovec
deleted the
elhimov/tntp-3886-adjust-failover-switch-output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of its output
switchdisplays commandswitch-statuswith the corresponding arguments that allows to check status of switching. This patch wraps uri argument of that command with quotes as it may contain characters that have special meaning for shell, thus it simplify subsequent call ofswitch-statuscommand because now it can be copy-pasted from the output as-is.Before:
After:
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #1194