Skip to content

cd: add CentOS 8 #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

cd: add CentOS 8 #1191

merged 1 commit into from
Aug 11, 2025

Conversation

Totktonada
Copy link
Member

@Totktonada Totktonada commented Aug 4, 2025

Similarly to commit 8485060 ("cd: add Ubuntu Noble") it is sometimes convenient to have the tt package right in the distro specific repository even if it is available in the general linux-rpm/static repository.

Since it costs nothing (the same RPM file is published to different repositories), I propose to publish the tt package to the el/8 repository as well.

See tarantool/installer.sh#42 for the story behind it.

Fixes #1192

@Totktonada
Copy link
Member Author

The Tests/check-commit-msg job is failed:

Spell checking commit message............................................Passed
Verify commit message format.............................................Failed
- hook id: gitlint
- exit code: 1

13: B8:reference_task_id Body does not match regex ((?m)^(?:Closes|Fixes|Related to|Part of|Needed for) #(?:[A-Z]+-)?\d+$)

The body doesn't actually match the regex. Should I link the installer.sh issue using the 'Related to' or 'Needed for' tag instead of a free form link?

@Totktonada Totktonada requested a review from dmyger August 4, 2025 22:08
@dmyger
Copy link
Collaborator

dmyger commented Aug 5, 2025

The body doesn't actually match the regex.

The checker expecting find in commit message a reference for task. It should be a line likes one of following:

Closes #123
Fixes #TNTP-123
Related to #123
Part of #TNTP-123
Needed for #123

Similarly to commit 8485060 ("cd: add Ubuntu Noble") it is
sometimes convenient to have the `tt` package right in the distro
specific repository even if it is available in the general
`linux-rpm/static` repository.

Since it costs nothing (the same RPM file is published to different
repositories), I propose to publish the `tt` package to the `el/8`
repository as well.

See tarantool/installer.sh#42 for the story behind it.

Fixes #1192
@Totktonada Totktonada force-pushed the deploy-to-el-8-repositories branch from 775123b to 288bfd2 Compare August 5, 2025 09:36
@Totktonada
Copy link
Member Author

OK, I've filed an issue with the same information that is present in the PR description. Now the linter shouldn't complain.

@oleg-jukovec oleg-jukovec merged commit 89d36d7 into master Aug 11, 2025
21 checks passed
@oleg-jukovec oleg-jukovec deleted the deploy-to-el-8-repositories branch August 11, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cd: add CentOS 8
3 participants