-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(menu): add icon support for Submenu in Rust and JS/TS APIs #13722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package Changes Through 736ebd7There are 7 changes which include tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with patch, tauri with minor, @tauri-apps/api with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Thank you for the PR! We just released 2.6 so we'll have to keep the dev branch open for patch changes for a few days/weeks. Just so you can prepare for a bit of a delay here :) Btw, the rust code comments aren't in english yet and your commits (expect the last 2 merge commits) aren't signed :) |
ca78be7 to
92038a7
Compare
Thank you for your feedback! |
Legend-Master
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, and works for me on Windows as well now, left some comments and will do a proper review tomorrow
|
@Legend-Master Fixed your comments. Also added set_icon and set_native_icon in crates/tauri/src/menu/submenu.rs. |
Legend-Master
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks!


This PR adds support for icons (custom and native) in submenus for both the Rust (
tauri) and JS/TS (@tauri-apps/api) APIs.Submenus can now display icons just like regular menu items.
SubmenuOptionsnow accepts aniconfield.Submenuclass providessetIconandsetNativeIconmethods.Closes: #11796
.changes/(minor:enhance)cargo testandcargo clippypass locally for the new code