fix: update action output handling for closed events to ensure accurate module release information #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te module release information
📋 Release Plan
📝 Changelog
|
|
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue with action output accuracy during the closed event by ensuring outputs reflect the state before releases are created. The fix prevents inconsistencies where output values would show incorrect information after the release process modifies the module state.
- Moved
setActionOutputs()call to execute before release operations to capture accurate pre-release state - Added documentation clarifying the behavior of output values during closed events
- Ensures
changed-modules-mapoutput correctly reflects modules that needed release before the actual release creation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main.ts | Moved setActionOutputs call before release handling to ensure accurate output state |
| README.md | Added documentation note explaining output behavior during closed events |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the accuracy of action outputs during the release process, particularly for the
closedevent. The main improvement ensures that outputs related to changed modules and release tags correctly reflect the state before a release is created, preventing inconsistencies in downstream usage.Action output accuracy improvements:
setActionOutputs(terraformModules)insrc/main.tsto occur before any release actions, ensuring outputs represent modules that needed release prior to the release being created.Documentation updates:
README.mdclarifying how thechanged-modules-mapoutput,latestTag, andreleaseTagbehave during theclosedevent, guiding users to reference the correct tag for the newly published version.Fixes #270