Skip to content

feat: resolve array values in Input of When expressions #9038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: resolve array values in Input of When expressions #9038

wants to merge 1 commit into from
+85 −2

Conversation

lcarva
Copy link
Contributor

@lcarva lcarva commented Sep 17, 2025 •
edited
Loading

Changes

This commits adds support for resolving the Input of When expression from array values, either from params or results. The replacement is the JSON marshaled version of the array value.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Array values can now be resolved in the `Input` attribute of `When` expressions

@lcarva
feat: resolve array values in Input of When expressions
917ec3b 
This commits adds support for resolving the Input of When expression
from array values, either from params or results. The replacement is the
JSON marshaled version of the array value.

Signed-off-by: Luiz Carvalho <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 17, 2025
@lcarva
Copy link
Contributor Author

lcarva commented Sep 17, 2025

/kind feature

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 17, 2025
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/when_types.go 100.0% 95.2% -4.8

@lcarva
Copy link
Contributor Author

lcarva commented Sep 18, 2025

I think the ci / e2e-tests / e2e tests (k8s-latest-minus-three, alpha) (pull_request) failure is bogus. I don't seem to have access to re-trigger that test but I suspect there's some flakiness there.

@vdemeester
Copy link
Member

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2025
@lcarva
Copy link
Contributor Author

lcarva commented Sep 29, 2025

Hmm ci / e2e-tests / e2e tests (k8s-latest-minus-three, alpha) is still failing. I'll dig more into it. Any help would be greatly appreciated.

@vdemeester
Copy link
Member

Hmm ci / e2e-tests / e2e tests (k8s-latest-minus-three, alpha) is still failing. I'll dig more into it. Any help would be greatly appreciated.

ah it didn't retrigger it yet (for some reason, the automation takes its time today). given it's the only one over a lot of e2e, it's probably just a flake.

@waveywaves waveywaves self-assigned this Sep 29, 2025
@waveywaves
Copy link
Member

/retest

1 similar comment
@vdemeester
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@twoGiants twoGiants Awaiting requested review from twoGiants

Assignees

@waveywaves waveywaves

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcarva @tekton-robot @vdemeester @waveywaves