Make sure SPIFFE ID is verified against workload's config#13
Merged
brendan-myers merged 3 commits intomainfrom Aug 4, 2025
Merged
Make sure SPIFFE ID is verified against workload's config#13brendan-myers merged 3 commits intomainfrom
brendan-myers merged 3 commits intomainfrom
Conversation
taonic
force-pushed
the
taonic/validate_spiffe_Id
branch
from
8bda148 to
11fbf9b
Compare
| type: "spiffe" | ||
| config: | ||
| trust_domain: "spiffe://company.com/" | ||
| spiffe_ids: ["spiffe://company.com/prod.company"] |
Collaborator
There was a problem hiding this comment.
Should match line 169 with the last element referring to a workload/service
taonic
force-pushed
the
taonic/validate_spiffe_Id
branch
from
11fbf9b to
6f41b32
Compare
taonic
force-pushed
the
taonic/validate_spiffe_Id
branch
from
6f41b32 to
4595336
Compare
Collaborator
|
lgtm. I also quickly updated the spiffe audience checks to use the same pattern as the spiffe ID checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify workload's identity via Spiffe ID instead of Trust Domain