Skip to content

Validate deployment options and test worker with versioning off and custom build ID#1163

Open
mjameswh wants to merge 2 commits intomasterfrom
worker-versioning-off-with-build-id
Open

Validate deployment options and test worker with versioning off and custom build ID#1163
mjameswh wants to merge 2 commits intomasterfrom
worker-versioning-off-with-build-id

Conversation

@mjameswh
Copy link
Contributor

Summary

  • Adds validation in WorkerConfig::build() rejecting default_versioning_behavior being Some(...) when use_worker_versioning is false, preventing stuck workflows caused by server-side rejection during workflow task completion
  • Adds integration test confirming a worker with use_worker_versioning=false and a custom build ID can successfully run workflows (deployment name appears in history)
  • Adds unit test for the new validation

Related: temporalio/sdk-typescript#1962

Test plan

  • versioning_off_with_custom_build_id — integration test (requires external server)
  • rejects_versioning_behavior_when_versioning_off — unit test passes locally

🤖 Generated with Claude Code

mjameswh and others added 2 commits March 13, 2026 17:37
…ustom build ID

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ustom build ID

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mjameswh mjameswh requested a review from a team as a code owner March 17, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants