Skip to content

Conversation

@jmaeagle99
Copy link
Contributor

@jmaeagle99 jmaeagle99 commented Nov 13, 2025

What was changed

Add [dependency injection[(https://learn.microsoft.com/en-us/dotnet/core/extensions/dependency-injection) support for Nexus services, similar to that of activities. Public methods were named similar to the Activity-based counter parts.

Why?

Enable registration of Nexus services via dependency injection in .NET host applications.

Checklist

  1. Closes [Feature Request] Support Nexus in Temporalio.Extensions.Hosting #536

  2. How was this tested:

  • Tests are not implemented yet
  1. Any docs updates needed?

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2025

CLA assistant check
All committers have signed the CLA.

@jmaeagle99 jmaeagle99 marked this pull request as ready for review November 17, 2025 17:33
@jmaeagle99 jmaeagle99 requested a review from a team as a code owner November 17, 2025 17:33
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole thing looks great. I reviewed it all including the tests and I think it's solid. Only one suggestion about changing the calls to be NexusService instead of Operations.

@jmaeagle99
Copy link
Contributor Author

Opened temporalio/samples-dotnet#118 to create a sample for these new APIs.

@jmaeagle99 jmaeagle99 requested a review from cretz November 17, 2025 19:55
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about invalid doc references (a bit sad CI didn't catch it tbh, may be an opportunity for improvement there). Feel free to merge when fixed.

@jmaeagle99 jmaeagle99 merged commit 5161e0b into temporalio:main Nov 17, 2025
16 of 17 checks passed
@jmaeagle99 jmaeagle99 deleted the nexus-di branch November 17, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Support Nexus in Temporalio.Extensions.Hosting

3 participants