Fix type mismatch in Environment::start() $rrCommand parameter#725
Open
jmortlock wants to merge 2 commits intotemporalio:masterfrom
Open
Fix type mismatch in Environment::start() $rrCommand parameter#725jmortlock wants to merge 2 commits intotemporalio:masterfrom
jmortlock wants to merge 2 commits intotemporalio:masterfrom
Conversation
Environment::start() declares $rrCommand as ?array but passes it directly to startRoadRunner() which expects ?string. This causes a TypeError at runtime. Change start() to accept ?string to match startRoadRunner(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@jmortlock is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
|
I think the command should stay of type array. See my proposed PR #726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Environment::start()declares$rrCommandas?arraybut passes it directly tostartRoadRunner()which expects?string, causing aTypeErrorat runtime:TypeError: Temporal\Testing\Environment::startRoadRunner(): Argument #1 ($rrCommand) must be of type ?string, array given
This was introduced in #714 (143a9e8) which changed
start()from?stringto?arraybut leftstartRoadRunner()as?string.Why?
Type mismatch
Checklist
N/A
How was this tested:
N/A
Any docs updates needed?
N/A