Fix #884: use Python 3.11 in nightly Cirq pre-release compatibility test #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python `typing` package changed in at least one respect between Python 3.10 and 3.11: in 3.10, it did not have the symbol `Self`). Cirq 1.6+ assumes that the `Self` is defined by importing `typing`, and fails in Python 3.10. This leads to the error seen in the CI runs https://github.com/tensorflow/quantum/actions/runs/17288698138/job/49070859286 ``` ImportError: cannot import name 'Self' from 'typing' ```
This workflow doesn't get triggered as a CI check. When making changes, unless we invoke it manually, you will not see the effects of the changes until the next run. For developer convenience, let's run it on pushes that change this file.
mhucka
changed the title
|
Note: because this workflow is purposefully not triggered as a CI check, the results of checks on this PR don't include this workflow itself. The output can be seen instead in my fork: https://github.com/mhucka/quantum/actions/runs/17310238898/job/49142715557 |
mhucka
added
the
area/ci
|
Reverting this back to a draft. Using 3.11 causes at least one compatibility problem that must be resolved first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python
typingpackage changed in at least one respect between Python 3.10 and 3.11: in 3.10, it did not have the symbolSelf). Cirq 1.6+ assumes that theSelfis defined by importingtyping, and fails in Python 3.10. This leads to the error seen in the CI runshttps://github.com/tensorflow/quantum/actions/runs/17288698138/job/49070859286
Since Cirq 1.6 requires Python 3.11 anyway, this workflow (for testing against the Cirq pre-release) should probably use 3.11. Doing so avoids the problem.
An additional change in this PR is to make this workflow trigger on pushes that affect this workflow file, so that the results of edits to the workflow can be seen immediately during development.