-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: Optional for public route_table_association #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
feat: option to create public route associate
feat: update doc
Hi @antonbabenko could you please to review this PR ? Thanks |
@antonbabenko @vietwow Any movement on this? This is exactly what we need for the exact same use case (firewall route tables) as the PR author. |
This PR has been automatically marked as stale because it has been open 30 days |
Hi @antonbabenko can we get your help to review this |
still waiting @antonbabenko for reviewing this |
This PR has been automatically marked as stale because it has been open 30 days |
Bump @antonbabenko please |
Description
The current module does not provide an option to disable the creation of public route associations. This PR hopes to include a variable to control that.
Motivation and Context
We create a network firewall outside of this module and associate the existing public subnet with the new firewall routing tables.
However, this introduces drift since we can't disable the association from this module.
We need to set this as optional for the public route association.
Breaking Changes
None as far as I can observe
var. create_public_route_association is default to true
How Has This Been Tested?
We tested this internally.