-
Notifications
You must be signed in to change notification settings - Fork 129
feat: allow set disk size & type on vm runners #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow set disk size & type on vm runners #235
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
befdf1b to
346e77f
Compare
|
Hi @apeabody @bharathkkb, can I get a review? the current 100gb size is too generous causing quotas to exceed when launching a handful of runners. |
|
/gcbrun |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the ability to configure the disk size and type for VM runners in both gh-runner-mig-container-vm and gh-runner-mig-vm modules. The changes are well-implemented, exposing disk_size_gb and disk_type as variables and updating the documentation accordingly. My review includes suggestions to add validation blocks for these new variables to improve the robustness of the modules by ensuring that only valid values are provided during configuration.
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @davidmontoyago!
Allow setting the disk size on
modules/gh-runner-mig-container-vmandmodules/gh-runner-mig-vmfor thin provisioning