feat: Add submodules for pub and sub #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q2w
force-pushed
the
submodules
branch
7 times, most recently
from
9e48feb to
77fe938
Compare
ktinubu
reviewed
Mar 14, 2025
ktinubu
reviewed
Mar 14, 2025
There was a problem hiding this comment.
Can you add an example of a push subscription that pushes to cloud run? the configuration should look something like:
push_subscriptions = [{
name = module.cloud-run-1.service_name
oidc_service_account_email = module.cloud-run-1.service_account_id.email
push_endpoint = module.cloud-run-1.service_uri
}]
You can look at the terraform generated from ADC as a reference
There was a problem hiding this comment.
Can we do this in a follow-up PR? I want this PR to simply divide the current root module into two modules.
ktinubu
reviewed
Mar 14, 2025
ktinubu
reviewed
Mar 14, 2025
ktinubu
reviewed
Mar 14, 2025
There was a problem hiding this comment.
Can you add an example of a pull subscription where the service account is set to the service account email of an instance template email
There was a problem hiding this comment.
Can we do this in follow-up PR?
ktinubu
suggested changes
Mar 14, 2025
q2w
force-pushed
the
submodules
branch
4 times, most recently
from
b353719 to
ff63099
Compare
ktinubu
approved these changes
Mar 17, 2025
bharathkkb
reviewed
Mar 17, 2025
Comment on lines
+17
to
+25
| output "topic" { | ||
| value = google_pubsub_topic.topic.name | ||
| description = "The name of the Pub/Sub topic" | ||
| } | ||
|
|
||
| output "topic_labels" { | ||
| value = google_pubsub_topic.topic.labels | ||
| description = "Labels assigned to the Pub/Sub topic" | ||
| } |
There was a problem hiding this comment.
Let's remove these unless necessary since there are just redirecting inputs as outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply creates 2 modules,
pubmodules creates topics and it's dependencysubmodules creates subscription and related iam bindings and other dependency.We will have follow up PRs to add IAM more bindings in each of the modules and adding connection for ADC.