support import offering from another fork #1047
Conversation
whoffler
requested review from
daniel-butler-irl and
toddgiguere
as code owners
cloudinfo/catalog.go
Outdated
| gitRoot, _ := common.GitRootPath(".") | ||
| commitID, _ := common.GetLatestCommitID(gitRoot) | ||
| repoName := filepath.Base(gitRoot) | ||
| repoUrl := fmt.Sprintf("https://github.com/terraform-ibm-modules/%s", repoName) |
There was a problem hiding this comment.
this wont work, cannot hardcode the repo, also needs to work on GE repos
There was a problem hiding this comment.
We have no knowledge of the the upstream remote is.
Would have to do something like get PR information with GitHub API to retrieve the remote the PR was opened against
GET https://api.github.com/repos/<your-username>/<repo>/pulls?head=<your-username>:<branch>
There was a problem hiding this comment.
I think common.GetBaseRepoAndBranch does what you need already, it should get the upstream. not the fork, its used for the upgrade tests to support forks
whoffler
force-pushed
the
fixFailingForkedPRTests
branch
from
3c5dc78 to
c740859
Compare
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 1.60.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
4 participants
Description
for issue - https://github.ibm.com/GoldenEye/issues/issues/15657
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers