added next steps #781
added next steps #781
Conversation
|
/run pipeline |
solutions/quickstart/outputs.tf
Outdated
| } | ||
|
|
||
| output "next_step_primary_url" { | ||
| value = "https://cloud.ibm.com/containers/cluster-management/clusters/${module.ocp_base.cluster_id}/overview" |
There was a problem hiding this comment.
This is not the Openshift dashbaord. This is the IBM Cloud cluster console page. The Openshift dashboard is based off the ingress domain. Perhaps we could keep this as a secondary one though
|
@pranjali-mundra Can you review the wording here please and approve if happy? |
solutions/quickstart/outputs.tf
Outdated
| } | ||
|
|
||
| output "next_step_primary_url" { | ||
| value = module.ocp_base.ingress_hostname |
There was a problem hiding this comment.
This is not correct.. gives value
https://cloud.ibm.com/projects/cc322438-95bb-46b9-b00a-a17a6fcc4739/configurations/ns5-openshift-qs-3b5bf5f75003778663c521c8c35ad277-0000.us-south.containers.appdomain.cloud
We need:
https://console-openshift-console.next-steps-openshift-qs-3b5bf5f75003778663c521c8c35ad277-0000.us-south.containers.appdomain.cloud/
Work needed to calculate the correct URL
|
/run pipeline |
|
The format of the OpenShift Console URL is
I have updated the code to fix it. |
| } | ||
|
|
||
| output "next_step_primary_url" { | ||
| value = "https://console-openshift-console.${module.ocp_base.ingress_hostname}/dashboards" |
There was a problem hiding this comment.
If this cluster had private only endpoint, this URL would not be valid
There was a problem hiding this comment.
Oh maybe I'm wrong here. Perhaps the private endpoint url is actually coming from the ingress_hostname? Lets deploy a private only cluster to validate
| } | ||
|
|
||
| output "next_step_primary_label" { | ||
| value = "Go to Openshift Cluster dashboard" |
There was a problem hiding this comment.
can we use the same text as UI:
| } | ||
|
|
||
| output "next_step_secondary_label" { | ||
| value = "Openshift Cluster Overview" |
There was a problem hiding this comment.
perhaps it should say overview page ?
There was a problem hiding this comment.
Don't forget to make same changes to fully configurable variation in this repo and also then in the quickstart and standard variations in https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone
Description
for issue - https://github.ibm.com/GoldenEye/issues/issues/13756#issuecomment-129327509
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers