-
Notifications
You must be signed in to change notification settings - Fork 2
DA improvement #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DA improvement #311
Conversation
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
@@ -16,8 +16,7 @@ variable "existing_resource_group_name" { | |||
|
|||
variable "prefix" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable is missing nullable=true
Please refer - https://terraform-ibm-modules.github.io/documentation/#/da-implementation-guidelines?id=prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take reference from similar PRs and address the points. Some points are highlighted here as well. Please make changes according to the module you are working on.
PRs for reference:
terraform-ibm-modules/terraform-ibm-watsonx-ai#148
terraform-ibm-modules/terraform-ibm-mq-cloud#148
terraform-ibm-modules/terraform-ibm-kms-all-inclusive#726
terraform-ibm-modules/terraform-ibm-secrets-manager-public-cert-engine#246
Description
Improving DA user experience.
Git issue
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers