Skip to content

feat: support for restapi major bump to 2.0 #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+11 −6
Open

feat: support for restapi major bump to 2.0 #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
876b90c
feat: support for restapi major bump to 2.0
shemau Aug 6, 2025
9daf5ae
Merge branch 'main' into major-restapi
shemau Aug 8, 2025
06454de
SKIP UPGRADE TEST
shemau Aug 8, 2025
9d1f8b3
fix: id_attribute to circumvent idempotent issues
shemau Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/complete/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ terraform {
}
restapi = {
source = "Mastercard/restapi"
version = ">= 1.20.0"
version = "1.20.0"
}
}
}
2 changes: 1 addition & 1 deletion modules/plan/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ You need the following permissions to run this module.
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.9.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.79.0, < 2.0.0 |
| <a name="requirement_restapi"></a> [restapi](#requirement\_restapi) | >= 1.20.0, <2.0.0 |
| <a name="requirement_restapi"></a> [restapi](#requirement\_restapi) | >= 1.20.0, < 3.0.0 |

### Modules

Expand Down
2 changes: 1 addition & 1 deletion modules/plan/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ terraform {
}
restapi = {
source = "Mastercard/restapi"
version = ">= 1.20.0, <2.0.0"
version = ">= 1.20.0, < 3.0.0"
}
}
}
2 changes: 1 addition & 1 deletion modules/quotas/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ You need the following permissions to run this module.
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.9.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.79.0, < 2.0.0 |
| <a name="requirement_restapi"></a> [restapi](#requirement\_restapi) | >= 1.20.0, <2.0.0 |
| <a name="requirement_restapi"></a> [restapi](#requirement\_restapi) | >= 1.20.0, < 3.0.0 |

### Modules

Expand Down
2 changes: 2 additions & 0 deletions modules/quotas/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ resource "restapi_object" "container_registry_storage_quota" {
data = jsonencode({
"storage_megabytes" : var.storage_megabytes
})
id_attribute = "storage_megabytes"
create_method = "PATCH"
create_path = "//${var.container_registry_endpoint}/api/v1/quotas"
destroy_method = "PATCH"
Expand All @@ -30,6 +31,7 @@ resource "restapi_object" "container_registry_traffic_quota" {
data = jsonencode({
"traffic_megabytes" : var.traffic_megabytes
})
id_attribute = "traffic_megabytes"
create_method = "PATCH"
create_path = "//${var.container_registry_endpoint}/api/v1/quotas"
destroy_method = "PATCH"
Expand Down
2 changes: 1 addition & 1 deletion modules/quotas/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ terraform {
}
restapi = {
source = "Mastercard/restapi"
version = ">= 1.20.0, <2.0.0"
version = ">= 1.20.0, < 3.0.0"
}
}
}
2 changes: 1 addition & 1 deletion solutions/fully-configurable/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ terraform {
}
restapi = {
source = "Mastercard/restapi"
version = "1.20.0"
version = "2.0.1"
}
}
}
1 change: 1 addition & 0 deletions tests/other_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ func TestRunCompleteExample(t *testing.T) {
Testing: t,
TerraformDir: completeDir,
Prefix: "complete-icr",
Region: region,
ResourceGroup: resourceGroup,
})
options.TerraformVars = map[string]interface{}{
Expand Down
2 changes: 2 additions & 0 deletions tests/pr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func TestRunUpgradeExample(t *testing.T) {
Testing: t,
TerraformDir: solutionFCDir,
Prefix: "upg-icr",
Region: region,
ResourceGroup: resourceGroup,
})
options.TerraformVars = map[string]interface{}{
Expand Down Expand Up @@ -190,6 +191,7 @@ func TestRunExistingResourcesExample(t *testing.T) {
Testing: t,
TerraformDir: solutionFCDir,
Prefix: "upg-icr",
Region: region,
ResourceGroup: resourceGroup,
})
options.TerraformVars = map[string]interface{}{
Expand Down