Skip to content

docs: added field description to enhance user-exp for S2S CRNs fields usage #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 13, 2025
Merged

docs: added field description to enhance user-exp for S2S CRNs fields usage #124

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
55e5465
docs: added field description to enhance user-exp for S2S CRNs fields…
vbontempi Sep 26, 2025
1e697b6
feat: added projects button support
vbontempi Sep 26, 2025
4823921
Merge branch 'main' into review_userexp
vbontempi Oct 1, 2025
a96a470
feat: moved description to variable and added virtual direct mapping
vbontempi Oct 6, 2025
5f87163
Merge branch 'review_userexp' of https://github.com/terraform-ibm-mod…
vbontempi Oct 6, 2025
e7827cf
feat: mapped mq-cloud output to s2s policy input
vbontempi Oct 6, 2025
f4d236b
feat: mapped mq-cloud output to s2s policy input
vbontempi Oct 6, 2025
5569876
fix: fixed plan name to lower case
vbontempi Oct 6, 2025
5d417e2
fix: setting default null value to existing_mq_capacity_crn DA input
vbontempi Oct 6, 2025
e571767
fix: fixed mq capacity instance to use in test
vbontempi Oct 6, 2025
318ed01
fix: forced bump of ibmcloud-terratest-wrapper to v1.60.11
vbontempi Oct 9, 2025
5a698ac
Merge branch 'main' into review_userexp
vbontempi Oct 9, 2025
6b8aa7f
feat: modified variable name and description
vbontempi Oct 10, 2025
652d5c6
Merge branch 'review_userexp' of https://github.com/terraform-ibm-mod…
vbontempi Oct 10, 2025
468f9eb
fix: SKIP UPGRADE TEST expected change of mq_s2s_policy_account_scope…
vbontempi Oct 13, 2025
34eec6e
Merge branch 'main' into review_userexp
ocofaigh Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common-dev-assets
Open in desktop
Submodule common-dev-assets updated 18 files
+1 −1 commonRenovateConfig.json
+5 −5 da-assets/da-dependency-updater/README.md
+1 −1 da-assets/da-dependency-updater/requirements.txt
+8 −3 da-assets/da-dependency-updater/update_da_dependencies.py
+222 −223 module-assets/.pre-commit-config.yaml
+1 −0 module-assets/ci/.typos.toml
+144 −12 module-assets/ci/install-deps.sh
+2 −2 module-assets/ci/terraformConfigInspect.py
+3 −5 module-assets/ci/terraformDocGoMod.py
+6 −8 module-assets/ci/terraformDocOverview.py
+3 −3 module-assets/ci/terraformDocs.py
+3 −3 module-assets/ci/terraformDocsUtils.py
+1 −1 module-assets/ci/validateIbmCatalogJson.py
+2 −4 module-assets/ci/validateJsonTemplate.py
+2 −2 scripts/update-source/run-update-src.py
+2 −0 stack-assets/.pre-commit-config.yaml
+1 −1 stack-assets/stack-updater/requirements.txt
+3 −4 stack-assets/stack-updater/update_stack_definition.py
13 changes: 12 additions & 1 deletion ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@
{
"reference_version": true,
"dependency_input": "existing_mq_capacity_crn",
"version_input": "mq_s2s_policy_target_crn"
"version_input": "existing_mq_capacity_crn"
},
{
"value": true,
Expand All @@ -302,6 +302,10 @@
"dependency_input": "secrets_manager_service_plan",
"version_input": "secrets_manager_service_plan",
"reference_version": true
},
{
"dependency_output": "capacity_crn",
"version_input": "mq_s2s_policy_target_crn"
}
]
}
Expand Down Expand Up @@ -552,6 +556,13 @@
{
"key": "mq_s2s_policy_target_crn"
},
{
"key": "existing_mq_capacity_crn",
"required": true,
"virtual": true,
"type": "string",
"description": "The existing MQ capacity instance for MQ on Cloud Deployable architecture."
Copy link
Contributor

@ocofaigh ocofaigh Oct 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would this say "Deployable architecture"? It doesn't have to come from a DA? oh wait I see what your trying to say... thinking about this....

},
{
"key": "db2_s2s_policy_enable"
},
Expand Down
15 changes: 15 additions & 0 deletions solutions/fully-configurable/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,18 @@ output "db2_s2s_resource_id" {
description = "Target Resource ID for the Service to Service policy for DB2 instance"
value = var.db2_s2s_policy_target_crn != null ? module.crn_parser_db2_instance_crn[0].service_instance : null
}

output "next_steps_text" {
value = "Enterprise Application Service instance dashboard"
description = "Access the Enterprise Application Service instance dashboard"
}

output "next_step_primary_label" {
value = "Enterprise Application Service Instance"
description = "Primary label"
}

output "next_step_primary_url" {
value = local.app_dashboard_url
description = "primary url"
}