Skip to content

Conversation

vkuma17
Copy link
Contributor

@vkuma17 vkuma17 commented Oct 8, 2025

Description

Use implicit dependency on secrets module
Issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vkuma17 vkuma17 requested review from akocbek and shemau as code owners October 8, 2025 14:08
@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 8, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 8, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 8, 2025

upgrade test is failing as expected because we have added triggers in time_sleep resource. This is expected and doesn't destroy actual infrastructure. sleep resource will get recreated. So, I am skipping the upgrade test.

2025-10-08T15:02:05.7915144Z         	Test:       	TestRunSecurityEnforcedUpgradeSolution
2025-10-08T15:02:05.7915600Z         	Messages:   	Resource(s) identified to be destroyed 
2025-10-08T15:02:05.7916036Z         	            	Name: wait_for_redis_authorization_policy
2025-10-08T15:02:05.7916548Z         	            	Address: module.redis.time_sleep.wait_for_redis_authorization_policy[0]
2025-10-08T15:02:05.7917040Z         	            	Actions: [delete create]
2025-10-08T15:02:05.7917393Z         	            	DIFF:
2025-10-08T15:02:05.7917707Z         	            	  Before: 
2025-10-08T15:02:05.7918049Z         	            		{"id":"2025-10-08T14:57:52Z","triggers":null}
2025-10-08T15:02:05.7918428Z         	            	  After: 
2025-10-08T15:02:05.7918997Z         	            		{"triggers":{"secrets_manager_guid":"79c6d411-c18f-4670-b009-b0044a238667","secrets_manager_region":"us-south"}}

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 8, 2025

/run pipeline

@vkuma17
Copy link
Contributor Author

vkuma17 commented Oct 8, 2025

/run pipeline

@ocofaigh ocofaigh merged commit f9e1f75 into main Oct 8, 2025
2 checks passed
@ocofaigh ocofaigh deleted the implicit-dep branch October 8, 2025 17:24
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.2.34 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants