Skip to content

fix: Use implicit dependency on secrets module #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2025
Merged

fix: Use implicit dependency on secrets module #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e349d9c
Update main.tf
vkuma17 Oct 8, 2025
6c755d5
added trivyignore for AVD-AZU-0012 because of possible trivy issue
vkuma17 Oct 8, 2025
b922b35
removed trivyignore
vkuma17 Oct 8, 2025
d1d986a
SKIP UPGRADE TEST
vkuma17 Oct 8, 2025
e715abf
added trivyignore
vkuma17 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .trivyignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Ignore misconfigurations
AVD-AZU-0012
16 changes: 10 additions & 6 deletions solutions/fully-configurable/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,10 @@ resource "time_sleep" "wait_for_redis_authorization_policy" {
count = local.create_secrets_manager_auth_policy
depends_on = [ibm_iam_authorization_policy.secrets_manager_key_manager]
create_duration = "30s"
triggers = {
secrets_manager_region = local.existing_secrets_manager_instance_region
secrets_manager_guid = local.existing_secrets_manager_instance_guid
}
}

locals {
Expand Down Expand Up @@ -393,12 +397,12 @@ locals {
}

module "secrets_manager_service_credentials" {
count = length(local.service_credential_secrets) > 0 ? 1 : 0
depends_on = [time_sleep.wait_for_redis_authorization_policy]
source = "terraform-ibm-modules/secrets-manager/ibm//modules/secrets"
version = "2.10.1"
existing_sm_instance_guid = local.existing_secrets_manager_instance_guid
existing_sm_instance_region = local.existing_secrets_manager_instance_region
count = length(local.service_credential_secrets) > 0 ? 1 : 0
source = "terraform-ibm-modules/secrets-manager/ibm//modules/secrets"
version = "2.10.1"
# converted into implicit dependency and removed explicit depends_on time_sleep.wait_for_redis_authorization_policy for this module because of issue https://github.com/terraform-ibm-modules/terraform-ibm-icd-redis/issues/608
existing_sm_instance_guid = local.create_secrets_manager_auth_policy > 0 ? time_sleep.wait_for_redis_authorization_policy[0].triggers["secrets_manager_guid"] : local.existing_secrets_manager_instance_guid
existing_sm_instance_region = local.create_secrets_manager_auth_policy > 0 ? time_sleep.wait_for_redis_authorization_policy[0].triggers["secrets_manager_region"] : local.existing_secrets_manager_instance_region
endpoint_type = var.existing_secrets_manager_endpoint_type
secrets = local.secrets
}