Skip to content

feat: add direct endpoint support #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add direct endpoint support #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1863,7 +1863,21 @@
"key": "existing_cos_resource_group"
},
{
"key": "existing_cos_endpoint_type"
"key": "existing_cos_endpoint_type",
"options": [
{
"displayname": "direct",
"value": "direct"
},
{
"displayname": "private",
"value": "private"
},
{
"displayname": "public",
"value": "public"
}
]
},
{
"key": "use_existing_cos_for_vpc_flowlogs"
Expand Down
8 changes: 4 additions & 4 deletions patterns/dynamic_values/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ variable "existing_cos_resource_group" {
}

variable "existing_cos_endpoint_type" {
description = "The endpoint type to use when accessing the existing COS instance, default is `public`."
description = "The endpoint type to use when accessing the existing COS instance. `direct` is the preferred endpoint type for re-platformed regions."
type = string
default = "public"
default = "direct"

validation {
error_message = "Endpoint type can only be `public` or `private`."
condition = contains(["public", "private", null], var.existing_cos_endpoint_type)
error_message = "Endpoint type can only be `public`, `private`, or `direct`."
condition = contains(["public", "private", "direct", null], var.existing_cos_endpoint_type)
}
}

Expand Down
8 changes: 4 additions & 4 deletions patterns/roks/module/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,13 @@ variable "existing_cos_resource_group" {
}

variable "existing_cos_endpoint_type" {
description = "The endpoint type to use when accessing the existing COS instance, default is `public`."
description = "The endpoint type to use when accessing the existing COS instance. `direct` is the preferred endpoint type for re-platformed regions."
type = string
default = "public"
default = "direct"

validation {
error_message = "Endpoint type can only be `public` or `private`."
condition = contains(["public", "private", null], var.existing_cos_endpoint_type)
error_message = "Endpoint type can only be `public`, `private`, or `direct`."
condition = contains(["public", "private", "direct", null], var.existing_cos_endpoint_type)
}
}

Expand Down
8 changes: 4 additions & 4 deletions patterns/roks/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,13 @@ variable "existing_cos_resource_group" {
}

variable "existing_cos_endpoint_type" {
description = "The endpoint type to use when accessing the existing COS instance, default is `public`."
description = "The endpoint type to use when accessing the existing COS instance. `direct` is the preferred endpoint type for re-platformed regions."
type = string
default = "public"
default = "direct"

validation {
error_message = "Endpoint type can only be `public` or `private`."
condition = contains(["public", "private", null], var.existing_cos_endpoint_type)
error_message = "Endpoint type can only be `public`, `private`, or `direct`."
condition = contains(["public", "private", "direct", null], var.existing_cos_endpoint_type)
}
}

Expand Down