Skip to content

Conversation

gmzcarlos
Copy link

Description

  • Fixed module's assignment output variable and value
  • Updated example's policy template

While working on terraform-ibm-modules/terraform-ibm-iam-account-settings#421, I noticed a typo in this module. Also, the access policy template in the example is not valid or supported by the API. Access policy templates cannot include attributes with values that can only exist in a single account, like serviceInstance.

Further question, the trusted profile templates support various identity types, but this module only supports one (CRNs), will that the support for the other identities will be added later?

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@gmzcarlos gmzcarlos force-pushed the tp-template-output branch from 894c497 to 328608d Compare May 28, 2025 14:28
key = "serviceInstance"
value = module.cos.cos_instance_guid
operator = "stringEquals"
}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed yesterday, the reason we added this was so we did not get policy clashes in our account as tests run. Each test would create a new COS instance meaning the policy attributes would always be unique.
But since you mentioned this config doesn't really make sense lets try to change it in a way where it still wont cause policy clashes in our account. I think you mentioned a unique tag could be used maybe? var.prefix will always be unique in the tests, so if we could use that as part of a tag, it will always be unique

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants