Skip to content

Replace Ruby SDK models with official Smithy repository #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[submodule "rules/models/aws-sdk-ruby"]
path = rules/models/aws-sdk-ruby
url = https://github.com/aws/aws-sdk-ruby
[submodule "rules/models/api-models-aws"]
path = rules/models/api-models-aws
url = https://github.com/aws/api-models-aws
2 changes: 0 additions & 2 deletions docs/rules/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1314,7 +1314,6 @@ These rules enforce best practices and naming conventions:
|aws_storagegateway_cache_invalid_disk_id|✔|
|aws_storagegateway_cache_invalid_gateway_arn|✔|
|aws_storagegateway_cached_iscsi_volume_invalid_gateway_arn|✔|
|aws_storagegateway_cached_iscsi_volume_invalid_network_interface_id|✔|
|aws_storagegateway_cached_iscsi_volume_invalid_snapshot_id|✔|
|aws_storagegateway_cached_iscsi_volume_invalid_source_volume_arn|✔|
|aws_storagegateway_cached_iscsi_volume_invalid_target_name|✔|
Expand Down Expand Up @@ -1347,7 +1346,6 @@ These rules enforce best practices and naming conventions:
|aws_storagegateway_stored_iscsi_volume_invalid_disk_id|✔|
|aws_storagegateway_stored_iscsi_volume_invalid_gateway_arn|✔|
|aws_storagegateway_stored_iscsi_volume_invalid_kms_key|✔|
|aws_storagegateway_stored_iscsi_volume_invalid_network_interface_id|✔|
|aws_storagegateway_stored_iscsi_volume_invalid_snapshot_id|✔|
|aws_storagegateway_stored_iscsi_volume_invalid_target_name|✔|
|aws_storagegateway_tape_pool_invalid_pool_name|✔|
Expand Down
1 change: 1 addition & 0 deletions rules/models/api-models-aws
Submodule api-models-aws added at 7e2048
1 change: 0 additions & 1 deletion rules/models/aws-sdk-ruby
Submodule aws-sdk-ruby deleted from 2d2b6d
2 changes: 2 additions & 0 deletions rules/models/aws_accessanalyzer_analyzer_invalid_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ func NewAwsAccessanalyzerAnalyzerInvalidTypeRule() *AwsAccessanalyzerAnalyzerInv
"ORGANIZATION",
"ACCOUNT_UNUSED_ACCESS",
"ORGANIZATION_UNUSED_ACCESS",
"ACCOUNT_INTERNAL_ACCESS",
"ORGANIZATION_INTERNAL_ACCESS",
},
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ func NewAwsAcmpcaCertificateInvalidSigningAlgorithmRule() *AwsAcmpcaCertificateI
attributeName: "signing_algorithm",
enum: []string{
"SHA256WITHECDSA",
"SHA384WITHECDSA",
"SHA512WITHECDSA",
"SHA256WITHRSA",
"SHA384WITHECDSA",
"SHA384WITHRSA",
"SHA512WITHECDSA",
"SHA512WITHRSA",
"SM3WITHSM2",
},
Expand Down
2 changes: 1 addition & 1 deletion rules/models/aws_alb_invalid_ip_address_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ func NewAwsALBInvalidIPAddressTypeRule() *AwsALBInvalidIPAddressTypeRule {
resourceType: "aws_alb",
attributeName: "ip_address_type",
enum: []string{
"ipv4",
"dualstack",
"dualstack-without-public-ipv4",
"ipv4",
},
}
}
Expand Down
2 changes: 1 addition & 1 deletion rules/models/aws_alb_invalid_load_balancer_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ func NewAwsALBInvalidLoadBalancerTypeRule() *AwsALBInvalidLoadBalancerTypeRule {
attributeName: "load_balancer_type",
enum: []string{
"application",
"network",
"gateway",
"network",
},
}
}
Expand Down
4 changes: 2 additions & 2 deletions rules/models/aws_alb_listener_invalid_protocol.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ func NewAwsALBListenerInvalidProtocolRule() *AwsALBListenerInvalidProtocolRule {
resourceType: "aws_alb_listener",
attributeName: "protocol",
enum: []string{
"GENEVE",
"HTTP",
"HTTPS",
"TCP",
"TCP_UDP",
"TLS",
"UDP",
"TCP_UDP",
"GENEVE",
},
}
}
Expand Down
4 changes: 2 additions & 2 deletions rules/models/aws_alb_target_group_invalid_protocol.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ func NewAwsALBTargetGroupInvalidProtocolRule() *AwsALBTargetGroupInvalidProtocol
resourceType: "aws_alb_target_group",
attributeName: "protocol",
enum: []string{
"GENEVE",
"HTTP",
"HTTPS",
"TCP",
"TCP_UDP",
"TLS",
"UDP",
"TCP_UDP",
"GENEVE",
},
}
}
Expand Down
2 changes: 1 addition & 1 deletion rules/models/aws_alb_target_group_invalid_target_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ func NewAwsALBTargetGroupInvalidTargetTypeRule() *AwsALBTargetGroupInvalidTarget
resourceType: "aws_alb_target_group",
attributeName: "target_type",
enum: []string{
"alb",
"instance",
"ip",
"lambda",
"alb",
},
}
}
Expand Down
4 changes: 2 additions & 2 deletions rules/models/aws_ami_invalid_architecture.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ func NewAwsAMIInvalidArchitectureRule() *AwsAMIInvalidArchitectureRule {
resourceType: "aws_ami",
attributeName: "architecture",
enum: []string{
"arm64",
"arm64_mac",
"i386",
"x86_64",
"arm64",
"x86_64_mac",
"arm64_mac",
},
}
}
Expand Down
2 changes: 1 addition & 1 deletion rules/models/aws_amplify_app_invalid_platform.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ func NewAwsAmplifyAppInvalidPlatformRule() *AwsAmplifyAppInvalidPlatformRule {
attributeName: "platform",
enum: []string{
"WEB",
"WEB_DYNAMIC",
"WEB_COMPUTE",
"WEB_DYNAMIC",
},
}
}
Expand Down
2 changes: 1 addition & 1 deletion rules/models/aws_amplify_branch_invalid_stage.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ func NewAwsAmplifyBranchInvalidStageRule() *AwsAmplifyBranchInvalidStageRule {
resourceType: "aws_amplify_branch",
attributeName: "stage",
enum: []string{
"PRODUCTION",
"BETA",
"DEVELOPMENT",
"EXPERIMENTAL",
"PRODUCTION",
"PULL_REQUEST",
},
}
Expand Down
4 changes: 2 additions & 2 deletions rules/models/aws_api_gateway_authorizer_invalid_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ func NewAwsAPIGatewayAuthorizerInvalidTypeRule() *AwsAPIGatewayAuthorizerInvalid
resourceType: "aws_api_gateway_authorizer",
attributeName: "type",
enum: []string{
"TOKEN",
"REQUEST",
"COGNITO_USER_POOLS",
"REQUEST",
"TOKEN",
},
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,26 +25,26 @@ func NewAwsAPIGatewayGatewayResponseInvalidResponseTypeRule() *AwsAPIGatewayGate
resourceType: "aws_api_gateway_gateway_response",
attributeName: "response_type",
enum: []string{
"DEFAULT_4XX",
"DEFAULT_5XX",
"RESOURCE_NOT_FOUND",
"UNAUTHORIZED",
"INVALID_API_KEY",
"ACCESS_DENIED",
"AUTHORIZER_FAILURE",
"API_CONFIGURATION_ERROR",
"AUTHORIZER_CONFIGURATION_ERROR",
"INVALID_SIGNATURE",
"AUTHORIZER_FAILURE",
"BAD_REQUEST_BODY",
"BAD_REQUEST_PARAMETERS",
"DEFAULT_4XX",
"DEFAULT_5XX",
"EXPIRED_TOKEN",
"MISSING_AUTHENTICATION_TOKEN",
"INTEGRATION_FAILURE",
"INTEGRATION_TIMEOUT",
"API_CONFIGURATION_ERROR",
"UNSUPPORTED_MEDIA_TYPE",
"BAD_REQUEST_PARAMETERS",
"BAD_REQUEST_BODY",
"INVALID_API_KEY",
"INVALID_SIGNATURE",
"MISSING_AUTHENTICATION_TOKEN",
"QUOTA_EXCEEDED",
"REQUEST_TOO_LARGE",
"RESOURCE_NOT_FOUND",
"THROTTLED",
"QUOTA_EXCEEDED",
"UNAUTHORIZED",
"UNSUPPORTED_MEDIA_TYPE",
"WAF_FILTERED",
},
}
Expand Down
6 changes: 3 additions & 3 deletions rules/models/aws_api_gateway_integration_invalid_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ func NewAwsAPIGatewayIntegrationInvalidTypeRule() *AwsAPIGatewayIntegrationInval
resourceType: "aws_api_gateway_integration",
attributeName: "type",
enum: []string{
"HTTP",
"AWS",
"MOCK",
"HTTP_PROXY",
"AWS_PROXY",
"HTTP",
"HTTP_PROXY",
"MOCK",
},
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ func NewAwsAPIGatewayRestAPIInvalidAPIKeySourceRule() *AwsAPIGatewayRestAPIInval
resourceType: "aws_api_gateway_rest_api",
attributeName: "api_key_source",
enum: []string{
"HEADER",
"AUTHORIZER",
"HEADER",
},
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ func NewAwsAPIGatewayStageInvalidCacheClusterSizeRule() *AwsAPIGatewayStageInval
attributeName: "cache_cluster_size",
enum: []string{
"0.5",
"1.6",
"6.1",
"118",
"13.5",
"1.6",
"237",
"28.4",
"58.2",
"118",
"237",
"6.1",
},
}
}
Expand Down
2 changes: 1 addition & 1 deletion rules/models/aws_apigatewayv2_api_invalid_protocol_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ func NewAwsApigatewayv2APIInvalidProtocolTypeRule() *AwsApigatewayv2APIInvalidPr
resourceType: "aws_apigatewayv2_api",
attributeName: "protocol_type",
enum: []string{
"WEBSOCKET",
"HTTP",
"WEBSOCKET",
},
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ func NewAwsApigatewayv2AuthorizerInvalidAuthorizerTypeRule() *AwsApigatewayv2Aut
resourceType: "aws_apigatewayv2_authorizer",
attributeName: "authorizer_type",
enum: []string{
"REQUEST",
"JWT",
"REQUEST",
},
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ func NewAwsApigatewayv2IntegrationInvalidIntegrationTypeRule() *AwsApigatewayv2I
attributeName: "integration_type",
enum: []string{
"AWS",
"AWS_PROXY",
"HTTP",
"MOCK",
"HTTP_PROXY",
"AWS_PROXY",
"MOCK",
},
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ func NewAwsApigatewayv2IntegrationInvalidPassthroughBehaviorRule() *AwsApigatewa
resourceType: "aws_apigatewayv2_integration",
attributeName: "passthrough_behavior",
enum: []string{
"WHEN_NO_MATCH",
"NEVER",
"WHEN_NO_MATCH",
"WHEN_NO_TEMPLATES",
},
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ func NewAwsApigatewayv2RouteInvalidAuthorizationTypeRule() *AwsApigatewayv2Route
resourceType: "aws_apigatewayv2_route",
attributeName: "authorization_type",
enum: []string{
"NONE",
"AWS_IAM",
"CUSTOM",
"JWT",
"NONE",
},
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ func NewAwsAppautoscalingPolicyInvalidPolicyTypeRule() *AwsAppautoscalingPolicyI
resourceType: "aws_appautoscaling_policy",
attributeName: "policy_type",
enum: []string{
"PredictiveScaling",
"StepScaling",
"TargetTrackingScaling",
"PredictiveScaling",
},
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,29 +25,29 @@ func NewAwsAppautoscalingPolicyInvalidScalableDimensionRule() *AwsAppautoscaling
resourceType: "aws_appautoscaling_policy",
attributeName: "scalable_dimension",
enum: []string{
"ecs:service:DesiredCount",
"ec2:spot-fleet-request:TargetCapacity",
"elasticmapreduce:instancegroup:InstanceCount",
"appstream:fleet:DesiredCapacity",
"dynamodb:table:ReadCapacityUnits",
"dynamodb:table:WriteCapacityUnits",
"dynamodb:index:ReadCapacityUnits",
"dynamodb:index:WriteCapacityUnits",
"rds:cluster:ReadReplicaCount",
"sagemaker:variant:DesiredInstanceCount",
"custom-resource:ResourceType:Property",
"comprehend:document-classifier-endpoint:DesiredInferenceUnits",
"comprehend:entity-recognizer-endpoint:DesiredInferenceUnits",
"lambda:function:ProvisionedConcurrency",
"cassandra:table:ReadCapacityUnits",
"cassandra:table:WriteCapacityUnits",
"kafka:broker-storage:VolumeSize",
"comprehend:document-classifier-endpoint:DesiredInferenceUnits",
"comprehend:entity-recognizer-endpoint:DesiredInferenceUnits",
"custom-resource:ResourceType:Property",
"dynamodb:index:ReadCapacityUnits",
"dynamodb:index:WriteCapacityUnits",
"dynamodb:table:ReadCapacityUnits",
"dynamodb:table:WriteCapacityUnits",
"ec2:spot-fleet-request:TargetCapacity",
"ecs:service:DesiredCount",
"elasticmapreduce:instancegroup:InstanceCount",
"elasticache:cache-cluster:Nodes",
"elasticache:replication-group:NodeGroups",
"elasticache:replication-group:Replicas",
"kafka:broker-storage:VolumeSize",
"lambda:function:ProvisionedConcurrency",
"neptune:cluster:ReadReplicaCount",
"sagemaker:variant:DesiredProvisionedConcurrency",
"rds:cluster:ReadReplicaCount",
"sagemaker:inference-component:DesiredCopyCount",
"sagemaker:variant:DesiredInstanceCount",
"sagemaker:variant:DesiredProvisionedConcurrency",
"workspaces:workspacespool:DesiredUserSessions",
},
}
Expand Down
20 changes: 10 additions & 10 deletions rules/models/aws_appautoscaling_policy_invalid_service_namespace.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,20 @@ func NewAwsAppautoscalingPolicyInvalidServiceNamespaceRule() *AwsAppautoscalingP
resourceType: "aws_appautoscaling_policy",
attributeName: "service_namespace",
enum: []string{
"ecs",
"elasticmapreduce",
"ec2",
"appstream",
"dynamodb",
"rds",
"sagemaker",
"custom-resource",
"comprehend",
"lambda",
"cassandra",
"kafka",
"comprehend",
"custom-resource",
"dynamodb",
"ec2",
"ecs",
"elasticache",
"elasticmapreduce",
"kafka",
"lambda",
"neptune",
"rds",
"sagemaker",
"workspaces",
},
}
Expand Down
Loading
Loading