-
-
Notifications
You must be signed in to change notification settings - Fork 335
Add csharpier formatter #1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add csharpier formatter #1513
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could we split this into smaller steps? Maybe start by adding the CSharpier config/tooling (disabled at first), then enable it gradually across the repo. WDYT?
Also, can we hook it into Cake so we can run a task to check formatting? Since our CI is built on Cake, that would fit perfectly.
What are the advantages for choosing this route?
What are the advantages of the formatter running for every project independently? A typical check across the whole project takes below 1s (after the first run). It's not significantly faster if run for each project independently. Also, if it's integrated into the cake process, you won't get feedback in the PR. The GitHub Action can do that. |
It's easier to review and to understand/see the changes. I can also take a look at the two commits and see how far I get. I mean, the first one is trivial.
Oh, I didn't mean it should be done independently. I was just thinking of having a Cake task so we can run it the same way locally and in CI. That's already been helpful with other tooling. I just don't know much about CSharpier and how it works (its tooling around). |
4900ecd
to
8fa5f1b
Compare
What does this PR do?
Adds csharpier.
Why is it important?
Related issues
How to test this PR
There are two commits in this MR:
dotnet csharpier format .
for the first time (big change)