Skip to content

Conversation

ozkanpakdil
Copy link

@ozkanpakdil ozkanpakdil commented Sep 13, 2025

Includes:

  • A new example demonstrating the use of the WithSSLSettings API for PostgreSQL with SSL/TLS.
  • SSL configuration options, server-side and mutual TLS examples.
  • Tests to validate SSL container setup and secure connection handling in PostgreSQL.

What does this PR do?

deliver extra ssl cinfig for dotnet API

Why is it important?

Go module had this , better to have it in dotnet too

Includes:
- A new example demonstrating the use of the `WithSSLConfig` API for PostgreSQL with SSL/TLS.
- SSL configuration options, server-side and mutual TLS examples.
- Tests to validate SSL container setup and secure connection handling in PostgreSQL.
Copy link

netlify bot commented Sep 13, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit b288bc1
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/68e0c4d278c0e000082d27ce
😎 Deploy Preview https://deploy-preview-1529--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

ozkanpakdil and others added 5 commits September 13, 2025 23:04
…ty across examples, tests, and documentation.
…rt wait strategy

- Use `TestContext.Current.CancellationToken` in async operations within SSL tests.
- Replace `UntilPortIsAvailable` with `UntilInternalTcpPortIsAvailable` for more accurate wait logic.
@HofmeisterAn HofmeisterAn added module An official Testcontainers module enhancement New feature or request labels Sep 21, 2025
@HofmeisterAn HofmeisterAn force-pushed the develop branch 3 times, most recently from 4900ecd to 8fa5f1b Compare October 3, 2025 20:17
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and for adding SSL support to the PostgreSQL module!

I noticed there's quite a bit of code in the PR for setting up certificates. I've added test certificates to the common project, which all test projects reference (#1545). That should remove a lot of the code, and we'll be able to reuse the certificates for other tests too, something I've been wanting to do for a while.

Also, we usually don't add examples for module-specific features. Those are covered by tests and docs. It'd be great if we could just add a small section to the PostgreSQL docs explaining how to configure the API for SSL.

Could you update the PR accordingly? Then I'll be happy to continue reviewing and get it finalized 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants