-
-
Notifications
You must be signed in to change notification settings - Fork 335
Add PostgreSQL SSL configuration example and tests #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add PostgreSQL SSL configuration example and tests #1529
Conversation
Includes: - A new example demonstrating the use of the `WithSSLConfig` API for PostgreSQL with SSL/TLS. - SSL configuration options, server-side and mutual TLS examples. - Tests to validate SSL container setup and secure connection handling in PostgreSQL.
… and related tests for improved clarity.
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ty across examples, tests, and documentation.
…rt wait strategy - Use `TestContext.Current.CancellationToken` in async operations within SSL tests. - Replace `UntilPortIsAvailable` with `UntilInternalTcpPortIsAvailable` for more accurate wait logic.
4900ecd
to
8fa5f1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and for adding SSL support to the PostgreSQL module!
I noticed there's quite a bit of code in the PR for setting up certificates. I've added test certificates to the common project, which all test projects reference (#1545). That should remove a lot of the code, and we'll be able to reuse the certificates for other tests too, something I've been wanting to do for a while.
Also, we usually don't add examples for module-specific features. Those are covered by tests and docs. It'd be great if we could just add a small section to the PostgreSQL docs explaining how to configure the API for SSL.
Could you update the PR accordingly? Then I'll be happy to continue reviewing and get it finalized 🙏.
Includes:
WithSSLSettings
API for PostgreSQL with SSL/TLS.What does this PR do?
deliver extra ssl cinfig for dotnet API
Why is it important?
Go module had this , better to have it in dotnet too