fix(localstack): accept community-archive as a valid tag#3601
fix(localstack): accept community-archive as a valid tag#3601johnduhart wants to merge 1 commit intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Summary by CodeRabbit
WalkthroughAdds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@modules/localstack/localstack.go`:
- Around line 37-43: The initial contains check using recentVersionTags only
tests the raw version string and can miss matches after you normalize by
stripping suffixes; in the function manipulating the local variable version,
after the suffix-strip block (the strings.LastIndexByte branch) re-run the
membership test against recentVersionTags (the same check as if
slices.Contains(recentVersionTags, version) { return true }) so normalized tags
like "community-archive-amd64" -> "community-archive" or "latest-amd64" ->
"latest" are recognized and return true.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 86c79808-cbac-4e68-a2d7-e2e90cc31b4f
📒 Files selected for processing (2)
modules/localstack/localstack.gomodules/localstack/localstack_test.go
Check the tag against recentVersionTags before stripping hyphen suffixes, so that tags containing hyphens like community-archive are correctly recognized as up-to-date versions. Fixes testcontainers#3592 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cd95678 to
c3c5448
Compare
Summary
community-archiveto therecentVersionTagslist so it is recognized as a modern (non-legacy) LocalStack tagrecentVersionTagscheck before the hyphen-suffix stripping inisMinimumVersion, so tags containing hyphens (likecommunity-archive) are matched correctlycommunity-archiveandcommunity-archive-amd64in both version check testsSee also: #3592
Test plan
TestIsLegacyVersionpasses withcommunity-archiveandcommunity-archive-amd64TestIsMinimumVersion2passes withcommunity-archiveandcommunity-archive-amd64🤖 Generated with Claude Code