Allow to use HealthCheck wait strategy by default #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cristianrgreco
added
enhancement
packages/testcontainers/src/docker-compose-environment/docker-compose-environment.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/docker-compose-environment/docker-compose-environment.ts
Outdated
Show resolved
Hide resolved
packages/testcontainers/src/generic-container/abstract-started-container.ts
Outdated
Show resolved
Hide resolved
|
I fixed some invalid WaitStrategy references in kafka and red panda. Tests pass locally |
|
@cristianrgreco |
Hey @digital88, apologies for the delay, been super busy with work lately! I still need to review this PR, but yes you're right it'll eventually get queued for a major release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#687
Had to augment ImageInspectInfo & ContainerInspectInfo because dockerode types do not expose HealthCheck nested property in Config property. I opened PR here but not sure when it will be accepted.