Skip to content

feat(core): DockerCompose: support list of env_files #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025

Conversation

mavcook
Copy link
Contributor

@mavcook mavcook commented Jul 19, 2025

It is useful to be able to pass a list of env_files, especially since you can pass a list of compose_file_names.
Builds upon #135, matching compose_file_name.

@mavcook
Copy link
Contributor Author

mavcook commented Aug 7, 2025

Not sure who is best to ask, so I will try @alexanderankin 😛

Could you or someone take a look at this when they have a chance? It is a backwards compatible 6 line change, so hopefully it will be painless. Thanks!

(Apologies for the pestering if you just haven't had time to see this PR yet)

Copy link
Member

@alexanderankin alexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mavcook
Copy link
Contributor Author

mavcook commented Aug 8, 2025

Thanks! It looks like the PR still needs approval to run the workflows before it can be merged?

@alexanderankin
Copy link
Member

i was gonna rerun the failed runs from before and then there was a merge which means all jobs have to run again, so i have to start over and hope for no pypi timeouts this time (they are quite rare to be fair)

@mavcook
Copy link
Contributor Author

mavcook commented Aug 8, 2025

oops my bad! I shouldn't have done that merge (thought it was blocking the PR)

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a072f3f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage        ?   81.79%           
=======================================
  Files           ?       14           
  Lines           ?      890           
  Branches        ?      140           
=======================================
  Hits            ?      728           
  Misses          ?      127           
  Partials        ?       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderankin alexanderankin merged commit fe206eb into testcontainers:main Aug 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants