fix(no-node-access): narrow detection to Testing Library queries #1064
+218
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
This PR changes the rule to only report native DOM event method calls (e.g.
click()
,select()
…) when the receiver is an element obtained via Testing Library queries (e.g.screen.getBy*,
findBy*,
queryBy*
, chains).Previously: the rule broadly reported any event handler method that was not fireEvent or userEvent.
Now: the rule reports only when event handler methods are called on results of Testing Library queries.
This reduces false positives while keeping the intended guidance.
Background
The prior, wide-scoped detection caused false positives when non–Testing Library APIs exposed methods with the same names as DOM event handlers.
Related reports:
Limitation: This rule does not report cases where an element is obtained directly from document, for example:
However, we consider this acceptable because, in our setup, the direct element retrieval itself (in this example,
getElementById
) is already reported, so the lack of a report here should not be an issue.This is a proposal PR. Please review, and if there are no concerns, I’ll proceed to broaden the test coverage afterward!