Skip to content

Changed findById() to findByPk() #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed findById() to findByPk() #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/resolvers/authorization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const isMessageOwner = async (
{ id },
{ models, me },
) => {
const message = await models.Message.findById(id, { raw: true });
const message = await models.Message.findByPk(id, { raw: true });

if (message.userId !== me.id) {
throw new ForbiddenError('Not authenticated as owner.');
Expand Down
2 changes: 1 addition & 1 deletion src/resolvers/message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default {
};
},
message: async (parent, { id }, { models }) => {
return await models.Message.findById(id);
return await models.Message.findByPk(id);
},
},

Expand Down
6 changes: 3 additions & 3 deletions src/resolvers/user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ export default {
return await models.User.findAll();
},
user: async (parent, { id }, { models }) => {
return await models.User.findById(id);
return await models.User.findByPk(id);
},
me: async (parent, args, { models, me }) => {
if (!me) {
return null;
}

return await models.User.findById(me.id);
return await models.User.findByPk(me.id);
},
},

Expand Down Expand Up @@ -68,7 +68,7 @@ export default {
updateUser: combineResolvers(
isAuthenticated,
async (parent, { username }, { models, me }) => {
const user = await models.User.findById(me.id);
const user = await models.User.findByPk(me.id);
return await user.update({ username });
},
),
Expand Down