Skip to content

Fixing an issue where valid HID responses are discarded #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
infinityis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing an issue where valid HID responses are discarded #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/shims/node-hid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import type {
ConnectedDevice,
WebVIADevice,
} from '../types/types';

var lastWriteTimestamp = Date.now();
// This is a bit cray
const globalBuffer: {
[path: string]: {currTime: number; message: Uint8Array}[];
Expand Down Expand Up @@ -143,7 +145,7 @@ const ExtendedHID = {
}

read(fn: (err?: Error, data?: ArrayBuffer) => void) {
this.fastForwardGlobalBuffer(Date.now());
this.fastForwardGlobalBuffer(lastWriteTimestamp);
if (globalBuffer[this.path].length > 0) {
// this should be a noop normally
fn(undefined, globalBuffer[this.path].shift()?.message as any);
Expand Down Expand Up @@ -172,6 +174,7 @@ const ExtendedHID = {
async write(arr: number[]) {
await this.openPromise;
const data = new Uint8Array(arr.slice(1));
lastWriteTimestamp = Date.now();
await this._hidDevice?._device.sendReport(0, data);
}
},
Expand Down